Skip to content

feat: node 22 and pnpm support - upgrade code and dependencies #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: node 22 and pnpm support - upgrade code and dependencies #108

wants to merge 2 commits into from

Conversation

@hcavarsan
Copy link

@hcavarsan hcavarsan commented May 11, 2024 •
edited
Loading

  • Upgrade all dependencies
  • Switch from npm to pnpm
  • Ensure Node 22 is working
  • Removed Google Analytics
  • Removed Sentry
  • Run pnpm lint, pnpm build, and pnpm dev successfully

Due to an Electron-Builder error, the pnpm build command requires a workaround. You'll need to add the following lines to your $HOME/.pnpmrc file:

node-linker = hoisted
public-hoist-pattern=*
shamefully-hoist=true
side-effects-cache=false

PS: tests and cypress need to be updated

@hcavarsan hcavarsan mentioned this pull request May 11, 2024
Open
@hcavarsan hcavarsan mentioned this pull request May 12, 2024
Closed
@brandonros
Copy link

brandonros commented Apr 5, 2025 

/Users/brandon/Documents/coding/kube-forwarder/node_modules/electron-vuex/node_modules/electron-store/index.js:8 Uncaught TypeError: Cannot read properties of undefined (reading 'app')
    at new ElectronStore (/Users/brandon/Documents/coding/kube-forwarder/node_modules/electron-vuex/node_modules/electron-store/index.js:8:48)
    at PersistedState.createStorage (/Users/brandon/Documents/coding/kube-forwarder/node_modules/electron-vuex/dist/persisted-state.js:45:14)
    at PersistedState.loadOptions (/Users/brandon/Documents/coding/kube-forwarder/node_modules/electron-vuex/dist/persisted-state.js:36:62)
    at /Users/brandon/Documents/coding/kube-forwarder/node_modules/electron-vuex/dist/persisted-state.js:153:20
    at /Users/brandon/Documents/coding/kube-forwarder/node_modules/vuex/dist/vuex.common.js:429:46
    at Array.forEach (<anonymous>)
    at new Store (/Users/brandon/Documents/coding/kube-forwarder/node_modules/vuex/dist/vuex.common.js:429:11)
    at ./src/renderer/store/index.js (index.js:23:1)
    at __webpack_require__ (bootstrap:22:1)
    at fn (hot module replacement:61:1)

when running locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hcavarsan @brandonros